On Sat, 2015-10-24 at 01:18 +0900, Mark Brown wrote:
> On Fri, Oct 23, 2015 at 10:40:58AM +0300, Andy Shevchenko wrote:
> > On Fri, 2015-10-23 at 08:11 +0900, Mark Brown wrote:
> > > The patch
>
> > > spi: dw: explicitly free IRQ handler in dw_spi_remove_host()
>
> > This one seems incomplete.
>
> > Yes, we already have a fix 02f20387e1bc in your tree.
>
> This *appears* to be the same commit you are following up on (please
> always include human readable descriptions)
This commit (9f89566) is a redundancy made by mistake.
>
> > This makes free_irq() call duplicate.
Currently in your for-next branch
void dw_spi_remove_host(struct dw_spi *dws)
{
dw_spi_debugfs_remove(dws);
free_irq(dws->irq, dws->master);
^^^ (1)
if (dws->dma_ops && dws->dma_ops->dma_exit)
dws->dma_ops->dma_exit(dws);
spi_shutdown_chip(dws);
free_irq(dws->irq, dws->master);
^^^ (2)
}
EXPORT_SYMBOL_GPL(dw_spi_remove_host);
> > Please, remove it from your tree
> > or do the revert.
>
> Are you saying that you have realised that your patch is broken since
> sending it? I've dropped this commit...
No, the commit 02f20387e1bc is rightful and should be present in the
tree.
P.S. Commit IDs as they appear in your for-next branch of SPI tree.
--
Andy Shevchenko <[email protected]>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
