On Fri, Dec 18, 2015 at 6:53 PM, Martin Sperl <ker...@martin.sperl.org> wrote: >> On 18.12.2015, at 14:32, Andy Shevchenko <andy.shevche...@gmail.com> wrote: >> On Fri, Dec 18, 2015 at 2:44 PM, <ker...@martin.sperl.org> wrote: >>> +static void __spi_transfer_dump_chunk(struct spi_device *spi, char *pre, >>> + const void *ptr, size_t start, >>> + size_t len) > ... > all comments fixed in next patch (mostly by rewriting code to use %*ph) > >> Documentation/printk-formats.txt is your friend. In particular a >> chapter about %*ph. > had to do a sprintf for the format itself as %*ph does not allow for > variable length - it still reduced the codesize...
I didn't get this. What variable length you are talking about? You may supply any amount of bytes you would like to print (will be printed up to 64 bytes in a line). >> How many users do you have for the helpers? I suggest to add a helper >> whenever there are at least 2+ users present. >> > As these are mostly convenience methods for use when debugging things > there are not typically that many users that would be needing those. > So I would prefer to keep them. Up to Mark, though in my practice most of the maintainers do not like orphaned helpers. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
