At 11:25 AM 6/4/2004, Brian F. G. Bidulock wrote:
Eugene,

These bugs have been documented for some time in the manpages.  Why not fix
insq and appq while your at it?  insq improperly frees the message  as well.

OK.  Fixed.  I don't know where appq() came from.  It is not present in Solaris or in the SVR4 STREAMS programming guide.  Anyway, it returns void so I made it free the message if anything fails.

Also, watch out for putnext and qreply that can also fail silently and free
the message (or not).

Nothing to watch out for.  These are void functions and always dispose of the message either by calling the appropriate driver put routine or freeing the message if something is wrong (q pointer NULL, q put function pointer NULL, etc).

-- Dave

Reply via email to