Hi Labbe,
Thanks for working on this. I've one small comment about this
patch. I'll the review of the actual crypto code up to the experts :)
On 05/13/2014 08:18 PM, LABBE Corentin wrote:
> Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com>
> ---
> arch/arm/boot/dts/sun7i-a20.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi
> b/arch/arm/boot/dts/sun7i-a20.dtsi
> index f4b00a5..714761b 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -930,6 +930,15 @@
> interrupt-controller;
> #interrupt-cells = <3>;
> interrupts = <1 9 0xf04>;
> + };
> +
> + crypto: crypto-engine@01c15000 {
> + compatible = "allwinner,sun7i-a20-crypto";
> + reg = <0x01c15000 0x1000>;
> + interrupts = <0 86 4>;
> + clocks = <&ahb_gates 5>, <&ss_clk>;
> + clock-names = "ahb", "mod";
> + status = "okay";
> };
> };
> };
>
status = "okay"; here is not necessary as it is the default, please drop it.
Other then that the dts (and bindings documentation) bits of this series
looks good.
Regards,
Hans
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
