Hi,
On 01/10/2014 12:31 AM, Ma Haijun wrote:
Hi,
<snip>
@@ -28,6 +32,12 @@
#define DRIVER_DESC "OHCI generic platform driver"
+#define OHCI_MAX_CLKS 3
I still recommend using of_count_phandle_with_args(np, "clocks",
"#clock-cells") to determine the number of clocks or the existence of clocks
property (-ENOENT)
See my mail to Alan, if he agrees with your suggested approach I'll change this.
<snip>
err_power:
if (pdata->power_off)
pdata->power_off(dev);
+err_put_clks:
+ while (--clk >= 0)
+ clk_disable_unprepare(priv->clks[clk]);
Is this a typo? Since the label suggests you want clk_put here.
Besides, I think we should do the same thing in the remove callback, even
though clk_put is an empty function currently.
Yes, type good catch, also good catch on needing to do the put on remove.
I'll fix both in v4 of the patch-set.
Regards,
Hans
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.