On Fri, Mar 14, 2014 at 10:33:32AM +0000, Ian Campbell wrote:

> Hi,
> 
> This is my first cut at an upstreamable series based upon the
> https://github.com/linux-sunxi/u-boot-sunxi.git#sunxi tree. The
> intention is to present a minimal starting point for upstreaming to
> which support for other processors, peripherals, boards etc can be
> added in the future. Therefore this has been stripped right back and
> currently supports only sun7i processors and the cubietruck
> board. Supported peripherals are UART, MMC and Ethernet.

Some global comments:
- If you haven't already, make sure it's all checkpatch clean.
- Use the SPDX tags rather than including the GPL boilerplate.
- Please re-word the commit messages.  The "how we got here / where this
  is from" is fine for the cover letter.
- Magic numbers need to be defined.

Thanks!

-- 
Tom

Attachment: signature.asc
Description: Digital signature

Reply via email to