[linux-sunxi] Re: [U-Boot] [PATCH v1 4/9] sunxi: initial generic sun7i cpu, board and start of day support

[Tom Rini]

On Fri, Mar 14, 2014 at 10:33:46AM +0000, Ian Campbell wrote:

[snip]
> +/* The sunxi internal brom will try to loader external bootloader
> + * from mmc0, nannd flash, mmc2.

Typo.

> +#ifdef CONFIG_SPL_BUILD
> +void sunxi_board_init(void)
> +{
> +     int power_failed = 0;
> +     unsigned long ramsize;
> +
> +     printf("DRAM:");
> +     ramsize = sunxi_dram_init();
> +     if (!ramsize) {
> +             printf(" ?");
> +             ramsize = sunxi_dram_init();
> +     }
> +     if (!ramsize) {
> +             printf(" ?");
> +             ramsize = sunxi_dram_init();
> +     }

We have to try 3 times?  What?

> +     /*
> +      * Only clock up the CPU to full speed if we are reasonably
> +      * assured it's being powered with suitable core voltage
> +      */
> +     if (!power_failed)
> +             clock_set_pll1(912000000);

Define that please.

-- 
Tom

signature.asc
Description: Digital signature