Hi,

On 11/03/14 05:31, Patrick Wood wrote:


On Sunday, March 9, 2014 10:13:08 AM UTC-4, Alejandro Mery wrote:



    On 09/03/14 13:09, Olliver Schinagl wrote:
     > Mnemoc,
     >
     > have you checked and merged this yet?

    thanks for the reminder. it fails to compile when hwmon is m

    like on sun7i_defconfig:
        LD      .tmp_vmlinux1
    drivers/built-in.o: In function `axp20_init_chip':
    
/srv/build/amery/allwinner/linux-sunxi/3.4/drivers/power/axp_power/axp20-mfd.h:149:

    undefined reference to `hwmon_device_register'
    drivers/built-in.o: In function `axp_mfd_remove':
    
/srv/build/amery/allwinner/linux-sunxi/3.4/drivers/power/axp_power/axp-mfd.c:368:

    undefined reference to `hwmon_device_unregister'
    make[1]: *** [.tmp_vmlinux1] Error 1
    make: *** [sub-make] Error 2

    build_sun7i/.config:CONFIG_AXP_HWMON=y
    build_sun7i/.config:CONFIG_HWMON=m

    in most defconfigs hwmon is n, should I y/y them on all defconfigs? can
    it be fixed to support hwmon=m?


Try this:

diff --git a/drivers/power/axp_power/Kconfig
b/drivers/power/axp_power/Kconfig
index 66aa6ac..4e942a9 100644
--- a/drivers/power/axp_power/Kconfig
+++ b/drivers/power/axp_power/Kconfig
@@ -38,7 +38,7 @@ config AXP_CHGCHANGE
  config AXP_HWMON
         depends on HWMON
-       bool "Enable the internal thermal monitoring support of AXP20X
chips"
+       tristate "Enable the internal thermal monitoring support of
AXP20X chips"
         default y
  endif # !AW_AXP

yes, that solved the problem. what about defconfig? m/m? y/y?

regards,
Alejandro Mery

--
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to