Hi,
On 03/21/2014 10:17 PM, Ian Campbell wrote:
> CHECK: extern prototypes should be avoided in .h files
> +extern void sunxi_reset(void);
>
> WARNING: suspect code indent for conditional statements (16, 20)
> + if (pin == SUNXI_GPA(9) || pin == SUNXI_GPA(14))
> + continue;
>
> WARNING: please, no space before tabs
> +#define SUNXI_MMC_CLK_DIVIDER_MASK ^I(0xff)$
>
> CHECK: braces {} should be used on all arms of this statement
> + if (file_size > SRAM_LOAD_MAX_SIZE) {
> [...]
> + } else
> [...]
>
> Signed-off-by: Ian Campbell <[email protected]>
Thanks, I've pushed this to the u-boot-sunxi.git sunxi branch.
Regards,
Hans
> ---
> arch/arm/include/asm/arch-sunxi/cpu.h | 2 +-
> arch/arm/include/asm/arch-sunxi/mmc.h | 2 +-
> drivers/net/sunxi_gmac.c | 2 +-
> tools/mksunxiboot.c | 3 ++-
> 4 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/include/asm/arch-sunxi/cpu.h
> b/arch/arm/include/asm/arch-sunxi/cpu.h
> index fb175b1..f0a8c48 100644
> --- a/arch/arm/include/asm/arch-sunxi/cpu.h
> +++ b/arch/arm/include/asm/arch-sunxi/cpu.h
> @@ -125,7 +125,7 @@ enum sunxi_boot_type_t {
> };
>
> void sunxi_board_init(void);
> -extern void sunxi_reset(void);
> +void sunxi_reset(void);
> #endif /* __ASSEMBLY__ */
>
> #endif /* _CPU_H */
> diff --git a/arch/arm/include/asm/arch-sunxi/mmc.h
> b/arch/arm/include/asm/arch-sunxi/mmc.h
> index 97b14c3..4219fc1 100644
> --- a/arch/arm/include/asm/arch-sunxi/mmc.h
> +++ b/arch/arm/include/asm/arch-sunxi/mmc.h
> @@ -48,7 +48,7 @@ struct sunxi_mmc {
>
> #define SUNXI_MMC_CLK_POWERSAVE (0x1 << 17)
> #define SUNXI_MMC_CLK_ENABLE (0x1 << 16)
> -#define SUNXI_MMC_CLK_DIVIDER_MASK (0xff)
> +#define SUNXI_MMC_CLK_DIVIDER_MASK (0xff)
>
> #define SUNXI_MMC_GCTRL_SOFT_RESET (0x1 << 0)
> #define SUNXI_MMC_GCTRL_FIFO_RESET (0x1 << 1)
> diff --git a/drivers/net/sunxi_gmac.c b/drivers/net/sunxi_gmac.c
> index 7a36581..b1df4b6 100644
> --- a/drivers/net/sunxi_gmac.c
> +++ b/drivers/net/sunxi_gmac.c
> @@ -29,7 +29,7 @@ int sunxi_gmac_initialize(bd_t *bis)
> #ifdef CONFIG_RGMII
> /* skip unused pins in RGMII mode */
> if (pin == SUNXI_GPA(9) || pin == SUNXI_GPA(14))
> - continue;
> + continue;
> #endif
> sunxi_gpio_set_cfgpin(pin, SUN7I_GPA0_GMAC);
> sunxi_gpio_set_drv(pin, 3);
> diff --git a/tools/mksunxiboot.c b/tools/mksunxiboot.c
> index 864841e..50fcda5 100644
> --- a/tools/mksunxiboot.c
> +++ b/tools/mksunxiboot.c
> @@ -113,8 +113,9 @@ int main(int argc, char *argv[])
> if (file_size > SRAM_LOAD_MAX_SIZE) {
> fprintf(stderr, "ERROR: File too large!\n");
> return EXIT_FAILURE;
> - } else
> + } else {
> load_size = ALIGN(file_size, sizeof(int));
> + }
>
> fd_out = open(argv[2], O_WRONLY | O_CREAT, 0666);
> if (fd_out < 0) {
>
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
