On Mon, 2014-03-24 at 00:21 +0100, Henrik Nordström wrote: > sön 2014-03-16 klockan 17:34 +0000 skrev Ian Campbell: > > As Alex explains in [0] this triple call likely dates back to before the > > DRAM > > init code used proper timings. It is not necessary any more. > > maybe, but not comfortable removing it without some test showing that > the problem is indeed solved.
Well all I can say is that it Worked For Me(tm) when I removed it. Base on that and upstream's feedback the code upstreamed in my initial attempt will only have a single call. If someone has a platform which requires these triple calls (and it sounds like you have one in mind) and it can't be fixed "properly" (e.g. by changing the DRAM timings or something similar) then the extra calls could be upstreamed as an independent patch which can come with a concrete rationale (I can't really do that now as the board I'm upstreaming doesn't appear to suffer from the issue). > We found it randomly failing on reboot some boards, I think it was > OLinuXino A13. Cold boot always worked. Then looked at Allwinner boot0 > code and copied retry from there. > > The code is from Sun Nov 4 22:32:41 2012 (ffe3d4fb) Thanks. Ian. -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
