Hi,
On 04/03/2014 09:38 PM, Ian Campbell wrote:
This series includes one refactoring suggested by Marek and the removal
of the busy waiting loops which was requested by Pantelis.
I didn't have much idea what timeouts to use. The Linux function
sunxi_mmc_oclk_onoff() uses a timeout of 2000msecs. This function
corresponds to the u-boot function mmc_update_clk() which busy waits for
0xfffff iterations. So I have translated a busy loop of 0xfffff to
2000msecs and 0xffff to 120 (roughly 2000/16).
These timeouts work for me on cubietruck to read and save the env as
well as to read kernel + dtb from the mmc card. I expect this is very
dependent on the specific board and SD card being used though, so any
testing would be appreciated.
Thanks for working on this. I've reviewed all the changes and they
look good, so I've applied them to the sunxi branch and pushed them.
Note I plan to rebase my sun6i work on top of this, test it and then
also push this. This will also involve some mmc changes.
I realize this may get a bit in the way of your upstreaming effort
(as in that you will need to redo some work to incorporate these
changes), and I'm sorry about that. But although upstreaming of
the sunxi support is very important I believe that adding sun6i
support also is important.
Regards,
Hans
Ian.
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
