Hi all,

On 04/21/2014 04:32 AM, Siarhei Siamashka wrote:
> These are some additional interesting DRAM clock frequencies. And
> they can be supported, while keeping the PLL5P clock speed at least
> not higher than the DRAM clock speed. PLL5P output is used to
> clock a lot of peripherals, so we need to be careful not to
> break them (or more like some buggy code in the sunxi-3.4
> kernel, which just sets hardcoded divisors in some places).
> 
> Having 396MHz is nice. It can be used with the tight DDR3-800
> timings (CL-tRCD-tRP-tRAS). For comparison, moving to 408MHz
> requires extra cycles for many of these timing parameters,
> which results in a latency increase.
> 
> Having 512MHz and 540MHz is also useful, because they provide better
> granularity of the DRAM clock frequency selection around DDR3-1066
> speed. And this is an interesting DRAM overclocking target.
> 
> The extra five branches add ~120 bytes of code if compiled
> for ARM and ~90 bytes of code if compiled for Thumb2.
> 
> Signed-off-by: Siarhei Siamashka <[email protected]>

Thanks!

Both patches looks good to me, if I receive no objections I'll be pushing
these to u-boot-sunxi.git sunxi branch during one of the coming days.

Regards,

Hans

> ---
>  arch/arm/cpu/armv7/sunxi/dram.c | 41 
> +++++++++++++++++++++++++++++++++++++----
>  1 file changed, 37 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/cpu/armv7/sunxi/dram.c b/arch/arm/cpu/armv7/sunxi/dram.c
> index 921f683..0fdab2f 100644
> --- a/arch/arm/cpu/armv7/sunxi/dram.c
> +++ b/arch/arm/cpu/armv7/sunxi/dram.c
> @@ -200,13 +200,46 @@ static void mctl_setup_dram_clock(u32 clk)
>       /* setup DRAM PLL */
>       reg_val = readl(&ccm->pll5_cfg);
>       reg_val &= ~CCM_PLL5_CTRL_M_MASK;               /* set M to 0 (x1) */
> -     reg_val |= CCM_PLL5_CTRL_M(CCM_PLL5_CTRL_M_X(2));
>       reg_val &= ~CCM_PLL5_CTRL_K_MASK;               /* set K to 0 (x1) */
> -     reg_val |= CCM_PLL5_CTRL_K(CCM_PLL5_CTRL_K_X(2));
>       reg_val &= ~CCM_PLL5_CTRL_N_MASK;               /* set N to 0 (x0) */
> -     reg_val |= CCM_PLL5_CTRL_N(CCM_PLL5_CTRL_N_X(clk / 24));
>       reg_val &= ~CCM_PLL5_CTRL_P_MASK;               /* set P to 0 (x1) */
> -     reg_val |= CCM_PLL5_CTRL_P(CCM_PLL5_CTRL_P_X(2));
> +     if (clk >= 540 && clk < 552) {
> +             /* dram = 540MHz, pll5p = 540MHz */
> +             reg_val |= CCM_PLL5_CTRL_M(CCM_PLL5_CTRL_M_X(2));
> +             reg_val |= CCM_PLL5_CTRL_K(CCM_PLL5_CTRL_K_X(3));
> +             reg_val |= CCM_PLL5_CTRL_N(CCM_PLL5_CTRL_N_X(15));
> +             reg_val |= CCM_PLL5_CTRL_P(1);
> +     } else if (clk >= 512 && clk < 528) {
> +             /* dram = 512MHz, pll5p = 384MHz */
> +             reg_val |= CCM_PLL5_CTRL_M(CCM_PLL5_CTRL_M_X(3));
> +             reg_val |= CCM_PLL5_CTRL_K(CCM_PLL5_CTRL_K_X(4));
> +             reg_val |= CCM_PLL5_CTRL_N(CCM_PLL5_CTRL_N_X(16));
> +             reg_val |= CCM_PLL5_CTRL_P(2);
> +     } else if (clk >= 496 && clk < 504) {
> +             /* dram = 496MHz, pll5p = 372MHz */
> +             reg_val |= CCM_PLL5_CTRL_M(CCM_PLL5_CTRL_M_X(3));
> +             reg_val |= CCM_PLL5_CTRL_K(CCM_PLL5_CTRL_K_X(2));
> +             reg_val |= CCM_PLL5_CTRL_N(CCM_PLL5_CTRL_N_X(31));
> +             reg_val |= CCM_PLL5_CTRL_P(2);
> +     } else if (clk >= 468 && clk < 480) {
> +             /* dram = 468MHz, pll5p = 468MHz */
> +             reg_val |= CCM_PLL5_CTRL_M(CCM_PLL5_CTRL_M_X(2));
> +             reg_val |= CCM_PLL5_CTRL_K(CCM_PLL5_CTRL_K_X(3));
> +             reg_val |= CCM_PLL5_CTRL_N(CCM_PLL5_CTRL_N_X(13));
> +             reg_val |= CCM_PLL5_CTRL_P(1);
> +     } else if (clk >= 396 && clk < 408) {
> +             /* dram = 396MHz, pll5p = 396MHz */
> +             reg_val |= CCM_PLL5_CTRL_M(CCM_PLL5_CTRL_M_X(2));
> +             reg_val |= CCM_PLL5_CTRL_K(CCM_PLL5_CTRL_K_X(3));
> +             reg_val |= CCM_PLL5_CTRL_N(CCM_PLL5_CTRL_N_X(11));
> +             reg_val |= CCM_PLL5_CTRL_P(1);
> +     } else  {
> +             /* any other frequency that is a multiple of 24 */
> +             reg_val |= CCM_PLL5_CTRL_M(CCM_PLL5_CTRL_M_X(2));
> +             reg_val |= CCM_PLL5_CTRL_K(CCM_PLL5_CTRL_K_X(2));
> +             reg_val |= CCM_PLL5_CTRL_N(CCM_PLL5_CTRL_N_X(clk / 24));
> +             reg_val |= CCM_PLL5_CTRL_P(CCM_PLL5_CTRL_P_X(2));
> +     }
>       reg_val &= ~CCM_PLL5_CTRL_VCO_GAIN;             /* PLL VCO Gain off */
>       reg_val |= CCM_PLL5_CTRL_EN;                    /* PLL On */
>       writel(reg_val, &ccm->pll5_cfg);
> 

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to