On Tue, 22 Apr 2014 11:55:29 -0700 (PDT)
Ivan Kozic <[email protected]> wrote:

> > Maybe this wiki page could be extended to provide some super simplistic 
> > explanation of the minimal actions that are needed to be taken. 
> >
> > Anyway, without having your fix presented as a patch, it is rather 
> > cumbersome to correctly apply your changes to the kernel sources and 
> > test them. 
> >
> 
> Just took a look at the link for making patches - doesn't seem too hard, so 
> I'll probably give it a go. 

Thanks.
 
> > Can we have a small test program, which reproduces the problem? 
> >
> 
>  No problem, I'll write a small app tomorrow and post the source here. 
> However this someone will have to have some kind of a camera to test it 
> properly. I'll try to make a short test with a UVC compliant camera - I 
> guess everyone has one these days :) so it'll be easy to reproduce.

I'm not sure if I follow. Why is camera necessary to reproduce a display
driver bug?

> > From what I can see, this code path is not taken at all for the XV 
> > overlay in the xf86-video-fbturbo driver and also in libvdpau-sunxi. 
> > Which suggests at least some redundancy in the disp ioctls. 
> >
> 
> Some? That's a very modest thing to say for something coming from AW :) 
> There are other ways to make digital zoom / control scaler (by always 
> setting new layer parameters with *_SET_PARA for instance), but using 
> scaler region is somehow most logical and simple. It's also most stable, as 
> *_SET_PARA breaks easily for some reason when applied several times in a 
> row. I was also wondering about this scaler reconfig, as it really seems a 
> bit redundant, but didn't have the time to go deeper into the code. For my 
> eye it seemed that the same results are achieved when commenting out the 
> whole reconfig except for input size of course, but I'd really have to 
> recheck the theory behind to make such a claim.

Let's check if I understand the situation correctly. You tried to use
a subset of sunxi disp ioctls, which don't seem to be used by the
others and found a bug (surprise, surprise). Then you provided a
description of what you think could be the culprit and some snippets
of code. And then you suggested that other people may want to try
converting these snippets of code into a proper patch to apply it to
the sunxi-3.4 kernel.

Well, I tried to explain that nobody is going to feel right about
picking up this code and adding their own Signed-off-by tag without
testing (which means, reproduce the bug and confirm that the patch
fixes it).

But if you submit a patch yourself with your own Signed-off-by tag,
then that's a completely different story. And much easier for the
others. After all, most people primarily care about having no
regressions for their own use cases.

> >
> > Thanks for bringing this up, just a little bit more details would be 
> > welcome. 
> >
> 
> No problem, your post on my previous thread made me want to actually try to 
> change something properly. I'll post back tomorrow when I write the stuff 
> out. 

Did you get stuck with something? Is any help needed?

-- 
Best regards,
Siarhei Siamashka

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to