On Mon, May 26, 2014 at 9:47 AM, Hans de Goede <[email protected]> wrote:
> With level triggered interrupt mask / unmask will get called for each > interrupt, doing the somewhat expensive mux setting on each unmask thus is > not a good idea. Instead move it to the set_type callback, which is typically > done only once for each irq. > > Signed-off-by: Hans de Goede <[email protected]> Yes move it out of mask/unmask but no, not into set_type(). Can you not use the irqchip startup()/shutdown() callbacks instead? And how come we have no clean separation between gpiochip and the pinmux parts here, why cant we just call pinctrl_request_gpio() and pinctrl_free_gpio() here instead? Or maybe pinctrl_gpio_direction_input() and have that set up the muxing in the pinctrl driver side? It looks slightly convoluted. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
