On Thu, 2014-09-25 at 20:09 +0100, Ian Campbell wrote:
> On Wed, 2014-09-24 at 16:01 +0800, Chen-Yu Tsai wrote:
> > The Colombus board is an A31 evaluation board from WITS Technology.
> > 
> > Signed-off-by: Chen-Yu Tsai <[email protected]>
> 
> > ---
> >  configs/Colombus_defconfig | 4 ++++
> >  1 file changed, 4 insertions(+)
> >  create mode 100644 configs/Colombus_defconfig
> > 
> > diff --git a/configs/Colombus_defconfig b/configs/Colombus_defconfig
> > new file mode 100644
> > index 0000000..16800de
> > --- /dev/null
> > +++ b/configs/Colombus_defconfig
> > @@ -0,0 +1,4 @@
> > +CONFIG_SYS_EXTRA_OPTIONS="COLOMBUS"
> 
> Does this do anything other than define an unused #define?
> 
> Ah, I suppose eventually it will cause the inclusion of a suitable dram
> file. Really ought to start moving things out of SYS_EXTRA though, but I
> don't think you need to shave that yakk just to get this patch in, so:
> 
> Acked-by: Ian Campbell <[email protected]>

Although I've just noticed that lacks a board/sunxi/MAINTAINERS entry.

I think there is no need to resend the whole series, just this one
patch. With this minor tweak I think it's time add this to
u-boot-sunxi#next.

Ian.

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to