> > For the record, this is required to have fast enough key presses with > > sun4i-keyboard (actually used on sun4i, sun5i and sun7i) on CWM > > recovery, an Android initramfs that allows easy flashing of the devices. > > With any lower sampling rate, close key presses are not distinguished > > and reported as one long press. > > After dropping the "For the record" part, the quoted text would make a > nice commit message for the patch. Other than this,
Agreed, the current one comes a bit out of the blue and lacks context. I do like to make title-ish first commit lines, but that's doesn't prevent from having a more complete decision below. > Acked-by: Siarhei Siamashka <[email protected]> > > BTW, when submitting patches for the sunxi-3.4 kernel, it is better to > use the "[PATCH 3.4]" header in order to avoid confusion. Thanks for the hint, I'll do that next time. Note that I have a few other patches I submitted earlier for the sunxi-3.4 branch that are still awaiting review on the list. > Also if you have some useful instructions about building > Android/Replicant for sunxi, some notes would be very much > welcome in the linux-sunxi wiki. Well, I didn't push anything to our upstream codebase yet, I'm waiting to have a bootable image first. Development happens at: http://git.code.paulk.fr/gitweb/?p=device_allwinner.git;a=summary for the Android userspace part and http://git.code.paulk.fr/gitweb/?p=kernel_allwinner_sunxi.git;a=summary for the kernel side. Please don't clone the kernel directly but fetch on top of the linux-sunxi one from github. I'll start a thread regarding how we handle documentation: part of it belongs on the linux-sunxi wiki and part on the Replicant wiki. I'd prefer to link back and forth rather than duplicating inforlation. -- Paul Kocialkowski, Replicant developer Replicant is a fully free Android distribution Website: http://www.replicant.us/ Redmine: http://redmine.replicant.us/
signature.asc
Description: This is a digitally signed message part
