Hi, Am 28.10.2014 um 21:16 schrieb Maxime Ripard: > Hi Chen-Yu, > > On Tue, Oct 28, 2014 at 05:50:41PM +0800, Chen-Yu Tsai wrote: >> The A80 Optimus board has 3 usable LEDs that are controlled via GPIO. >> >> This patch adds support for 2 of them which are driver by GPIOs in the >> main pin controller. The remaining one uses GPIO from the R_PIO >> controller, which we don't support yet. >> >> Signed-off-by: Chen-Yu Tsai <[email protected]> >> --- >> arch/arm/boot/dts/sun9i-a80-optimus.dts | 25 +++++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun9i-a80-optimus.dts >> b/arch/arm/boot/dts/sun9i-a80-optimus.dts >> index 25fe775..91eda76 100644 >> --- a/arch/arm/boot/dts/sun9i-a80-optimus.dts >> +++ b/arch/arm/boot/dts/sun9i-a80-optimus.dts >> @@ -64,6 +64,13 @@ >> /* Enable internal pull-up */ >> allwinner,pull = <1>; >> }; >> + >> + led_pins_optimus: led_pins@0 {
Here too, led-pins@0 would be more in line with DT conventions.
>> + allwinner,pins = "PH0", "PH1";
>> + allwinner,function = "gpio_out";
>> + allwinner,drive = <0>;
>> + allwinner,pull = <0>;
>> + };
>> };
>>
>> uart0: serial@07000000 {
>> @@ -78,4 +85,22 @@
>> status = "okay";
>> };
>> };
>> +
>> + leds {
>> + compatible = "gpio-leds";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&led_pins_optimus>;
>> +
>> + led2 {
>> + label = "a80_optimus:led2:usr";
>
> We're usually using a dash instead of an underscore as a separator.
I wonder, why a80_? The board is labeled "Allwinner Tech Optimus Board",
and the Cubietruck LEDs are not prefixed with a20_ either.
>> + gpios = <&pio 7 0 0>;
>> + };
>> +
>> + /* led3 is on PM15, in R_PIO */
>
> You were saying that there is three LEDs, why start the numbering at
> 2?
They are labeled "LED2", "LED4", "LED3" right-to-left.
Additionally there's a "PWR" LED, maybe that counts as number 1...
>> +
>> + led4 {
>> + label = "a80_optimus:led4:usr";
>> + gpios = <&pio 7 1 0>;
>> + };
>> + };
>> };
>
> The rest of your patchset is fine for me, we just need to get the
> pinctrl driver merged first :)
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
signature.asc
Description: OpenPGP digital signature
