Hi,
On 12/05/2014 09:13 AM, Vishnu Patekar wrote:
On Fri, Dec 5, 2014 at 1:13 AM, Hans de Goede <[email protected]> wrote:
Hi,
Interesting patch-set. I knew the A10 / A20 had ps/2 but I did not expect
anyone
to use it :)
I'll try to make some time to give this a try an A10, guess I need to
desolder a ps2
female connector from some old board :)
Yes, I just checked, A10 and A20 have same PS2 addresses, clocks,
interrupts.
It should work for A10. However, I've only A20 Lime2 board. It can be
modified for A10 as well once patch is accepted for A20.
The problem is that we want the compatible string to point to the *earliest*
model with the ip block, but we can only do that once we now sure they are
actually the same. As said I'll try to get this tested coming Tuesday, I think
we should wait with merging the final patches until this is clear and we know
which compatible string to use.
That is not a reason to stop working on it though, please do address the
remarks and create a v2 of the patchset.
In fact, I'll send the newer version of patch after implementing the review
comments by Priit Laes and Dmitry Torokhov.
On 12/03/2014 11:47 PM, vishnupatekar wrote:
---
.../bindings/input/allwinner,sun7i-a20-ps2.txt | 22
++++++++++++++++++++
1 file changed, 22 insertions(+)
create mode 100644 Documentation/devicetree/bindings/input/allwinner,
sun7i-a20-ps2.txt
diff --git a/Documentation/devicetree/bindings/input/allwinner,sun7i-a20-ps2.txt
b/Documentation/devicetree/bindings/input/allwinner,sun7i-a20-ps2.txt
new file mode 100644
index 0000000..63b6214
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/allwinner,sun7i-a20-ps2.txt
@@ -0,0 +1,22 @@
+* Device tree bindings for Allwinner A20 PS2 host controller
+
+A20 PS2 is dual role controller(PS2 host and PS2 device). These bindings
are for PS2 host controller.
+IBM compliant IBM PS2 and AT-compatible keyboard and mouse can be
connected.
+
+Required properties:
+
+ - reg : Offset and length of the register set for the
device.
+ - compatible : Should one of the following:
+ - "allwinner,sun7i-a20-ps2"
This very like should be allwinner,sun4i-a10-ps2 as the A10 has the ps/2
controller
too. I'll try to test this coming Tuesday (when I'm at my local
hackerspace).
As said above, we really ought to fix this before merging a final version,
I'll do my best to test your code on A10 soon.
+ - interrupts : The interrupt line connected to the P2WI peripheral.
+ - clocks : The gate clk connected to the P2WI peripheral.
Copy paste error, I'm pretty sure you don't want P2WI here.
Agreed, It's certainly a copy paste error.:) I'll fix it in next version of
patch which I'll be sending in a day or two.
Regards,
Hans
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
