Am 10.06.2015 um 17:49 schrieb 'Simos Xenitellis' via linux-sunxi:
On Wed, Jun 10, 2015 at 4:52 PM, Heiko Schröter <
[email protected]> wrote:

sorry forgot the mailing text to allwinner:


Dear Sirs,

in the User Manual seems to be some errors concerning the THS register.

A)
3.19.3 Themal Measurement
Page 248
T=(Val - 1669)/6.25 gives wrong results.
It seems that T is of by 16.
T=(Val - 1669 + 100)*16/100 seem to give correct results; divide result by
100
OR T=(Val - 1669 + 100)/6.25 (float point calc)

B)
Page 251 THS Control Register 1
The Bits are offset by 1.
31:8 / / /
7   R/W  0x1  CHOP_TEMP_EN
6:5  / / /
4   R/W  0x0  DATA_EN
3:0 R/W  0x1  /

Could you pls check if the errors reported are correct ?


A comment here. You did not mention which version of the User Manual you
are referring to.
A link to https://linux-sunxi.org/A23#Documentation would probably suffice.

I am not sure how often these documents are updated;
My suggestion is to also file an issue at
https://github.com/allwinner-zh/documents/issues
which shows the correction.

Simos

The Manual Version etc were in the Subject line of the mail.
I thought that would help to forward the mail to the correct addressee.

Will have a look at the link you supplied.

Heiko











Am 10.06.2015 um 15:48 schrieb Heiko Schröter:


Sended to [email protected].

It is exactly the Manual you've linked here:
https://github.com/allwinner-zh/documents/issues/10
Version 1.0, August 2013

Heiko


Am 10.06.2015 um 15:23 schrieb 'Simos Xenitellis' via linux-sunxi:


On Wed, Jun 10, 2015 at 3:00 PM, schroete <
[email protected] <mailto:
[email protected]>> wrote:

     Hello,

     i've written a short kernel module to readout the onchip thermal
     register of the A23 CPU.
     Should also work on other Allwinner CPUs with thermal base
     register at 0x01C25000.

     Pls note that there are errors in the A23 User Manual, Page 248.
     Allwinner is informed but no feedback so far.


How did you contact Allwinner?

There is a report at https://github.com/allwinner-zh/documents/issues/10
for newer A23 documentation.

Simos

     The calculus of the T value is wrong by an offset of 0x10.
     Also the bit numbering of the CTRL1 is wrong by one bit.

     Tested with A20 CPU on cubietruck and kernel 3.4.103-sunxi7.
     Compiles also under Kernel 4.1rc7 (but no Tests been done so far.)

     It is my first kernel module and may be some find it also useful
     and could test in their setup if the module compiles and loads.

     The results are output via /proc/a23_thermal. Value needs to be
     divided by 100.

     If a driver already exists pls let me know.


--
You received this message because you are subscribed to the Google
Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected] <mailto:
[email protected]>.
For more options, visit https://groups.google.com/d/optout.





--
-----------------------------------------------------------------------
Dipl.-Ing. Heiko Schröter
Institute of Environmental Physics (IUP)   phone: ++49-(0)421-218-62092
Institute of Remote Sensing (IFE)          fax:   ++49-(0)421-218-62070
University of Bremen (FB1)
P.O. Box 330440               email:  [email protected]
Otto-Hahn-Allee 1
28359 Bremen
Germany
-----------------------------------------------------------------------




--
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to