On 23 June 2015 at 21:35, Hans de Goede <[email protected]> wrote:
> Hi,
>
> On 06/05/2015 05:54 PM, Michal Suchanek wrote:
>>
>> Hello,
>>
>> I tried to patch my kernel to load the axp20x driver to control the axp152
>> chip.
>>
>> The power key works and I can power off the system.
>>
>> However, on next power on the system would power off again when the ehci
>> or ohci controller is probed.
>>
>> I disabled the controllers and everything appears to work OK otherwise.
>>
>> Anyone has any idea why probing the USB controller would upset the axp?
>>
>> I disabled the regulator part of the mfd so regulators should presumably
>> not get triggered.
>
>
> Thanks for your work on this. I've cleaned up your patch-set a bit and
> pushed it to
> my sunxi-wip branch.
>
> I've tried the cleaned up patches on my A10s-OLinuxIno-Micro board and I do
> not
> see any problems whether I use USB or not. If I were you I would check your
> powersupply.

I was using an USB hub which did not cause problems previously but I
don't thing the power supply on it is very good so that might be the
problem.

>
> I'm going to submit the cleaned up version of your patches upstream (with
> you as
> the author).

Thanks for looking into this. I did not get to looking at the new
feature patches yet and the basic functionality makes quite a bit of
difference for the Olinuxino.

BTW the A20X IRQ enums seem to be numbered to match the bit position
in the register, including the extra effort to assign the value after
the gap - except for the last 4 which are 1 off due to the unused bit
before the GPIO IRQs.

Thanks

Michal


>
>>
>>   /* IRQs */
>> -enum {
>> +enum axp20x_irqs {
>>         AXP20X_IRQ_ACIN_OVER_V = 1,
>>         AXP20X_IRQ_ACIN_PLUGIN,
>>         AXP20X_IRQ_ACIN_REMOVAL,
>> @@ -193,12 +212,34 @@ enum {
>>         AXP20X_IRQ_TIMER,
>>         AXP20X_IRQ_PEK_RIS_EDGE,
>>         AXP20X_IRQ_PEK_FAL_EDGE,
>> +       AXP20X_dummy,
>>         AXP20X_IRQ_GPIO3_INPUT,
>>         AXP20X_IRQ_GPIO2_INPUT,
>>         AXP20X_IRQ_GPIO1_INPUT,
>>         AXP20X_IRQ_GPIO0_INPUT,
>>   };
>>
>> +enum axp152_irqs {
>> +       AXP152_IRQ_ACIN_PLUGIN = 2,
>> +       AXP152_IRQ_ACIN_REMOVAL,
>> +       AXP152_IRQ_VBUS_PLUGIN = 5,
>> +       AXP152_IRQ_VBUS_REMOVAL,
>> +       AXP152_IRQ_DCDC1_V_LOW = 10,
>> +       AXP152_IRQ_DCDC2_V_LOW,
>> +       AXP152_IRQ_DCDC3_V_LOW,
>> +       AXP152_IRQ_DCDC4_V_LOW,
>> +       AXP152_IRQ_PEK_SHORT = 14,
>> +       AXP152_IRQ_PEK_LONG,
>> +       AXP152_IRQ_TIMER,
>> +       AXP152_IRQ_PEK_RIS_EDGE,
>> +       AXP152_IRQ_PEK_FAL_EDGE,
>> +       AXP152_dummy,
>> +       AXP152_IRQ_GPIO3_INPUT,
>> +       AXP152_IRQ_GPIO2_INPUT,
>> +       AXP152_IRQ_GPIO1_INPUT,
>> +       AXP152_IRQ_GPIO0_INPUT,
>> +};
>> +
>>   enum axp288_irqs {
>>         AXP288_IRQ_VBUS_FALL     = 2,
>>         AXP288_IRQ_VBUS_RISE,
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to