On Tue, 18 Aug 2015 08:36:06 -0000 Cam Hutchison <[email protected]> wrote:
> Siarhei Siamashka <[email protected]> writes: > > >On Tue, 18 Aug 2015 01:53:24 +0800 > >Vishnu Patekar <[email protected]> wrote: > > >> Add soc id for A33, A83T, and H3. > >> Also updated sram table info. > >> > >> Signed-off-by: VishnuPatekar <[email protected]> > >> --- > >> fel.c | 18 ++++++++++++++++++ > >> 1 file changed, 18 insertions(+) > >> > >> diff --git a/fel.c b/fel.c > >> index c53be60..42c69eb 100644 > >> --- a/fel.c > >> +++ b/fel.c > >> @@ -194,6 +194,9 @@ void aw_fel_print_version(libusb_device_handle *usb) > >> case 0x1651: soc_name="A20";break; > >> case 0x1650: soc_name="A23";break; > >> case 0x1639: soc_name="A80";break; > >> + case 0x1667: soc_name="A33";break; > >> + case 0x1673: soc_name="A83T";break; > >> + case 0x1680: soc_name="H3";break; > >> } > >> > >> printf("%.8s soc=%08x(%s) %08x ver=%04x %02x %02x scratchpad=%08x %08x > >> %08x\n", > >> @@ -408,6 +411,21 @@ soc_sram_info soc_sram_info_table[] = { > >> .thunk_addr = 0x46E00, .thunk_size = 0x200, > >> .swap_buffers = a31_sram_swap_buffers, > >> }, > >> + { > >> + .soc_id = 0x1667, /* Allwinner A33 */ > >> + .thunk_addr = 0x46E00, .thunk_size = 0x200, > >> + .swap_buffers = a31_sram_swap_buffers, > >> + }, > >> + { > >> + .soc_id = 0x1673, /* Allwinner A83T */ > >> + .thunk_addr = 0x46E00, .thunk_size = 0x200, > >> + .swap_buffers = a31_sram_swap_buffers, > >> + }, > >> + { > >> + .soc_id = 0x1680, /* Allwinner H3 */ > >> + .thunk_addr = 0x46E00, .thunk_size = 0x200, > >> + .swap_buffers = a31_sram_swap_buffers, > >> + }, > >> { 0 } /* End of the table */ > >> }; > >> > > >If I understand it correctly, you have only tested this yourself on A33? > >We should only add the table entries for the tested hardware. > > >It would be great if people could confirm FEL boot working on Allwinner > >A83T and Allwinner H3. > > I have tested this on an H3 (Orange Pi Plus) and it works. I was able to > load and run boot0_sdcard.fex via fel and have it boot the SD card. > > Tested-by: Cam Hutchison <[email protected]> Thanks for testing on an H3! Now we just need to find somebody with an A83T board. I still would prefer this bigger patch to be split into separate A33, H3 and A83T parts. So that we have no confusion regarding the Tested-by tags. If Vishnu submits a v2 patchset with all these comments addressed, he can have my Acked-by. -- Best regards, Siarhei Siamashka -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
