Hi Danny,

On Sun, Dec 06, 2015 at 07:53:07PM +0100, Danny Milosavljevic wrote:
> Hi,
> 
> this is the fourth version of the patch that adds inputs to sun4i-codec.
> 
> The inputs added are:
> - FM-In Left and Right
> - Line-In Left and Right
> - Mic1-In
> - Mic2-In
> 
> Changes compared to v3 are:
> - Names of the input are not uppercase anymore.
> - bit index constants are now named as in the A20 user manual v1.4
> - added Mic1-In, Mac2-In
> - added Mic1 and Mic2 Pre-Amplifiers.
> 
> I successfully tested it using alsamixer, headphones, a radio and my ears.
> Note that because of missing capturing support I tested only the mixing.
> 
> Still TODO are:
> - sun4i_codec_micin_gain_scale should have an entry for 0 dB at 0.
>   How?
> - maybe the Mic Preamps should be listed in the routes. 
>   It works as it is now, though.
> - right now when I press F4 in alsamixer, the Mic1-In Pre-Amplifier Gain 
>   is missing its muting switch. WTF...
>   How does ALSA (or alsamixer) know which controls are "Capture"?

Thanks for your patch. Please send it to the relevant recipients (you
can have the list using scripts/get_maintainer.pl) so that the review
process can get started. Otherwise, your patch will never be picked.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Attachment: signature.asc
Description: Digital signature

Reply via email to