On Mon, Jan 04, 2016 at 10:30:11PM +0100, Marcus Weseloh wrote: > Hi, > > 2016-01-04 20:11 GMT+01:00 Maxime Ripard <[email protected]>: > [...] > >> The SPI core calls set_cs before a transfer, but the SUN4I_CTL_CS_MANUAL > >> flag is only set in transfer one. This leads to the following pattern on > >> the chip-select line (with runtime power-management on every transfer, > >> without it only on the first one): > >> > >> activate, deactivate, activate, transfer, deactivate > >> > >> Moving the configuration of the SUN4I_CTL_CS_MANUAL flag from transfer_one > >> to set_cs removes this problem. > >> > >> Signed-off-by: Marcus Weseloh <[email protected]> > > > > It looks sane, but you didn't Cc the appropriate mailing lists. > > Thanks for the review! I didn't Cc the mailing lists on purpose, as my > main question for this patch was: how should I submit it? As a single > patch or as part of the other SPI fixes and feature additions I'm > currently working on. I think your implicit answer is: just submit it > on it's own, which I will do now.
Yeah, it's pretty much stand alone, it doesn't really need to be part of any serie. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: Digital signature
