On Thu, Feb 11, 2016 at 2:20 PM, Krzysztof Adamski <k...@japko.eu> wrote: > On Thu, Feb 11, 2016 at 02:17:41PM +0100, Linus Walleij wrote: >> >> On Tue, Feb 2, 2016 at 10:21 PM, Krzysztof Adamski <k...@japko.eu> wrote: >> >>> sunxi_pmx_set accepts pin number and then calculates offset by >>> subtracting pin_base from it. sunxi_pinctrl_gpio_get, on the other hand, >>> gets offset so we have to convert it to pin number so we won't get >>> negative value in sunxi_pmx_set. >>> >>> This was only used on A10 so far, where there is only one GPIO chip with >>> pin_base set to 0 so it didn't matter. However H3 also requires this >>> workaround but have two pinmux sections, triggering problem for PL port. >>> >>> Signed-off-by: Krzysztof Adamski <k...@japko.eu> >> >> >> Waiting for Maxime to review this. I guess this patch can be merged >> independently of the other patches? > > Yes it can but it won't have any effect, as stated in the commit message, > since other SoCs either don't use this flag or have only one port so theri > pin_base=0.
Who cares as long as it will be used eventually. Merged v4 as stated earlier. Yours, Linus Walleij -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.