On Thu, 17 Mar 2016 19:38:54 +0100
Bernhard Nortmann <[email protected]> wrote:

> From: Lourens Rozema <[email protected]>
> 
> Tested-by: Bernhard Nortmann <[email protected]>
> ---

> This picks up a long-standing pull request from the github repo that seemingly
> noone cared to take forward to the mailing list. The one-line change looks 
> sane,
> and reportedly is needed for proper operation when issuing repeated sunxi-fel
> commands on Mac OS X. NextThingCo also uses it in their
> https://github.com/NextThingCo/sunxi-tools/commit/09cf8e3

Thanks! This is indeed a generic fix for a libusb API misuse bug and not
something that is somehow specific to Mac OS X.

Considering that NextThingCo has apparently tested and taken this patch
into use, it makes a lot of sense to apply this fix too.

>  fel.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fel.c b/fel.c
> index 59f0f72..c81077f 100644
> --- a/fel.c
> +++ b/fel.c
> @@ -1437,6 +1437,7 @@ int main(int argc, char **argv)
>               aw_fel_execute(handle, uboot_entry);
>       }
>  
> +     libusb_release_interface(handle, 0);
>  #if defined(__linux__)
>       if (iface_detached >= 0)
>               libusb_attach_kernel_driver(handle, iface_detached);

Reviewed-by: Siarhei Siamashka <[email protected]>

-- 
Best regards,
Siarhei Siamashka

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to