On Sun, 20 Mar 2016 14:03:24 +0100
Bernhard Nortmann <[email protected]> wrote:

> Am 20.03.2016 um 13:53 schrieb Siarhei Siamashka:
> > Thanks, also adding an extra
> >
> >                || busnum < 0 || devnum < 0
> >
> > check here would make it perfect.
> >
> > If the user tries to provide negative numbers in the command line, then
> > it is reasonable to fail with an error instead of silently reverting to
> > the default "pick any FEL device" behaviour.  
> 
> Should we extend that to be "|| busnum <= 0 || devnum <= 0"?
> 
> Afaik, a zero bus or device number would be impossible to match anyway.

Yes, this makes sense. Feel free to do this adjustment when pushing the
patch to git.

-- 
Best regards,
Siarhei Siamashka

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to