On Sun, 20 Mar 2016 15:18:10 +0100 Bernhard Nortmann <[email protected]> wrote:
> One thing that came to my mind while playing around with this: Should we > add something like this to the commit message? > > "Caveat: Use these commands with caution! Errors during execution of > the scratch buffer code, e.g. attempts to access an invalid memory > location, might crash the FEL; requiring you to reset the device." We already have a detailed explanation about all the implications in the commit message here: http://permalink.gmane.org/gmane.comp.hardware.netbook.arm.sunxi/21153 The new "readl" and "writel" commands are the examples of the "advanced-command-which-uploads-and-executes-code" mentioned there. > I think this particular patch has merits of it own, and might be useful > even if isolated from the rest of the series (e.g. when implementing a > future "sid" command). This patch is just unsafe if pushed alone, that's why it implicitly depends on the other "fel: Move the temporary scratch buffer under the IRQ stack" patch. And instead of cluttering the documentation with the "Use these commands with caution!" warnings (which many people will miss or ignore anyway), it's better to do a proper job in the first place. > By now it has received a bit of testing on various hardware (during the > course of https://github.com/linux-sunxi/sunxi-tools/issues/37), so feel > free to commit it. > > Reviewed-by: Bernhard Nortmann <[email protected]> Thanks. -- Best regards, Siarhei Siamashka -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
