________________________________
From: Boris Brezillon <[email protected]>
Sent: Saturday, April 16, 2016 3:07 AM
To: Han Xu
Cc: Roger Quadros; Tony Lindgren; Wenyou Yang; Josh Wu; Boris Brezillon;
Richard Weinberger; [email protected]; David Woodhouse; Brian
Norris; Kamal Dasu; Ezequiel Garcia; Stefan Agner; [email protected];
Nicolas Ferre; Jean-Christophe Plagniol-Villard; Alexandre Belloni; Thomas
Petazzoni; Gregory CLEMENT; Jason Cooper; Sebastian Hesselbarth; Andrew Lunn;
Daniel Mack; Haojian Zhuang; Robert Jarzmik;
[email protected]; [email protected];
[email protected]; Maxime Ripard; Chen-Yu Tsai;
[email protected]; Zhou Wang; Alex Smith; Harvey Hunt
Subject: Re: [PATCH 06/12] mtd: nand: gpmi: rely on generic DT parsing done in
nand_scan_ident()
Hi Han,
On Fri, 1 Apr 2016 14:54:26 +0200
Boris Brezillon <[email protected]> wrote:
> The core now takes care of parsing generic DT properties in
> nand_scan_ident() when nand_set_flash_node() has been called.
> Rely on this initialization instead of calling of_get_nand_xxx()
> manually.
Can you review/test this patch? I'd like to have the whole series
merged in this release.
Thanks,
Boris
>
> Signed-off-by: Boris Brezillon <[email protected]>
> ---
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 21 ++++++++++-----------
> 1 file changed, 10 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> index 8122c69..c6e8a1c 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -25,7 +25,6 @@
> #include <linux/mtd/partitions.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> -#include <linux/of_mtd.h>
> #include "gpmi-nand.h"
> #include "bch-regs.h"
>
> @@ -1914,16 +1913,6 @@ static int gpmi_nand_init(struct gpmi_nand_data *this)
> /* Set up swap_block_mark, must be set before the gpmi_set_geometry()
> */
> this->swap_block_mark = !GPMI_IS_MX23(this);
>
> - if (of_get_nand_on_flash_bbt(this->dev->of_node)) {
> - chip->bbt_options |= NAND_BBT_USE_FLASH | NAND_BBT_NO_OOB;
> -
> - if (of_property_read_bool(this->dev->of_node,
> - "fsl,no-blockmark-swap"))
> - this->swap_block_mark = false;
> - }
> - dev_dbg(this->dev, "Blockmark swapping %sabled\n",
> - this->swap_block_mark ? "en" : "dis");
> -
> /*
> * Allocate a temporary DMA buffer for reading ID in the
> * nand_scan_ident().
> @@ -1938,6 +1927,16 @@ static int gpmi_nand_init(struct gpmi_nand_data *this)
> if (ret)
> goto err_out;
>
> + if (chip->bbt_options & NAND_BBT_USE_FLASH) {
> + chip->bbt_options |= NAND_BBT_NO_OOB;
> +
> + if (of_property_read_bool(this->dev->of_node,
> + "fsl,no-blockmark-swap"))
> + this->swap_block_mark = false;
> + }
> + dev_dbg(this->dev, "Blockmark swapping %sabled\n",
> + this->swap_block_mark ? "en" : "dis");
> +
Sorry for late, it's fine for me.
Acked-by: Han xu <[email protected]>
> ret = gpmi_init_last(this);
> if (ret)
> goto err_out;
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[http://free-electrons.com/wp-content/header-images/buildroot-course-940x198.jpg]<http://free-electrons.com/>
Embedded Linux Experts - Free Electrons<http://free-electrons.com/>
free-electrons.com
Free Electrons is an engineering company specialized in embedded Linux and more
generally in Free and Open Source software for embedded systems.
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
