[linux-sunxi] Re: [PATCH 2/2] ARM: dts: sunxi: Add pll3 and pll7 clock to sun[47]i.dtsi

[Alexander Syring]

Hi Priit, I found two typos in your sun7i-a20.dtsi patch. >‎ Enable pll3 and pll7 clocks that are needed by display clocks. >---  > arch/arm/boot/dts/sun7i-a20.dtsi | 41 >++++++++++++++++++++++++++++++++++++++++ ‎ > 1 file changed, 41 insertions(+) ‎ > >diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi >b/arch/arm/boot/dts/sun7i-a20.dtsi  >index bf5d056..2688512 100644  >--- a/arch/arm/boot/dts/sun7i-a20.dtsi  >+++ b/arch/arm/boot/dts/sun7i-a20.dtsi ‎ >@@ -187,6 +187,15 @@ ‎ >                         clock-output-names = "osc24M";  >                 };  >  ‎ >+                osc3M: osc3M_clk {  >+                        #clock-cells = <0>;  >+                        compatible = "fixed-factor-clock";  >+                        clock-div = <8>;  >+                        clock-mult = <1>;  >+                        clocks = <&osc24M>;  >+                        clock-output-names = "osc3M";  >+                };  >+‎  >                 osc32k: clk@0 {  >                         #clock-cells = <0>;  >                         compatible = "fixed-clock";  >@@ -211,6 +220,22 @@  >                                              "pll2-4x", "pll2-8x"; ‎ >                 };  >   >+                pll3: clk@01c20010 {  >+                        #clock-cells = <0>;  >+                        compatible = "allwinner,sun4i-a10-pll3-clk";  >+                        reg = <0x01c20010 0x4>;  >+                        clock = <&osc3M>; ‎ I think it should be clocks with a s. >+                        clock-output-names = "pll3"; ‎ >+};  >+  >+                pll3x2: pll3x2_clk {  >+                        #clock-cells = <0>; ‎ >+                        compatible = "fixed-factor-clock";  >+                        clock-div = <1>;  >+                        clock-mult = <2>;  >+                        clock-output-names = "pll3-2x";  >+                };  >+‎  >                 pll4: clk@01c20018 {  >                         #clock-cells = <0>;  >                         compatible = "allwinner,sun7i-a20-pll4-clk";  >@@ -236,6 +261,22 @@  >                                              "pll6_div_4";  >                 };  >  ‎ >+                pll7: clk@01c20030 {  >+                        #clock-cells = <0>;  >+                        compatible = "allwinner,sun4i-a10-pll3-clk";  >+                        reg = <0x01c20030 0x4>;  >+                        clock = <&osc3M>; ‎ And here a s too. >+                        clock-output-names = "pll7";  >+}; ‎ >+  >+                pll7x2: pll7x2_clk {  >+                        #clock-cells = <0>;  >+                        compatible = "fixed-factor-clock";  >+                        clock-div = <1>;  >+                        clock-mult = <2>;  >+                        clock-output-names = "pll7-2x";  >+                };  >+  >                 pll8: clk@01c20040 {  >                         #clock-cells = <0>;  >                         compatible = "allwinner,sun7i-a20-pll4-clk";  >-- ‎ >2.8.1  Best Alex -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.