On Thu, Nov 24, 2016 at 6:57 PM, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Thu, Nov 24, 2016 at 01:17:13AM +0000, Andre Przywara wrote: >> The Allwinner H5 SoC is closely related to the H3 SoC, so select the >> basic pinctrl driver and the DMA driver to let a defconfig kernel boot >> on those boards. >> >> Signed-off-by: Andre Przywara <andre.przyw...@arm.com> >> --- >> arch/arm64/Kconfig.platforms | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms >> index cfbdf02..8300677 100644 >> --- a/arch/arm64/Kconfig.platforms >> +++ b/arch/arm64/Kconfig.platforms >> @@ -5,8 +5,12 @@ config ARCH_SUNXI >> select GENERIC_IRQ_CHIP >> select PINCTRL >> select PINCTRL_SUN50I_A64 >> + select PINCTRL_SUN8I_H3 >> + select PINCTRL_SUN8I_H3_R >> + select DMA_SUN6I > > I'm not sure I want to get an ever growing select which will be an > union of all the drivers that all the arm64 Allwinner SoCs will > require. > > Select leaves no option to disable that option, and we have defconfig > to deal with that nicely.
I have to agree. We should only select things that aren't selectable by the user. In our case, that's only the pinctrl drivers. We should use default y (ARCH_SUNXI && ARM64) for every driver that has a prompt entry in Kconfig. ChenYu -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.