2017年3月20日 17:33于 Maxime Ripard <[email protected]>写道: > > On Sat, Mar 18, 2017 at 04:19:43AM +0800, Icenowy Zheng wrote: > > In commit e66f81bbd746 ("clk: sunxi-ng: Implement factors offsets"), the > > final formula of NKMP clocks' recalc_rate is refactored; however, the > > refactored formula broke the calculation due to some C language operand > > priority problem -- the priority of operand >> is lower than * and /, > > makes the formula being parsed as "(parent_rate * n * k) >> (p / m)", but > > it should be "(parent_rate * n * k >> p) / m". > > > > Add the pair of parentheses to fix up this issue. This pair of > > parentheses used to exist in the old formula. > > > > Fixes: commit e66f81bbd746 ("clk: sunxi-ng: Implement factors offsets") > > You shouldn't have commit here.
Thanks for reminding me. > > > Signed-off-by: Icenowy Zheng <[email protected]> > > Fixed it, and applied, thanks! > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
