Hi, On Thu, Oct 26, 2017 at 02:57:00PM +0000, Joonas Kylmälä wrote: > Maxime Ripard: > > On Sun, Oct 22, 2017 at 12:19:56PM +0300, Joonas Kylmälä wrote: > >> Most of the boards use the mmc0 pins and their attributes defined in > >> mmc0_pins_a and mmc0_cd_pin. Let's default to those by moving the > >> pinctrl attributes to the dtsi file. This makes it easier to modify > >> device trees in the future as there is only one place to change the > >> pinctrl attributes. > >> > >> As a side effect this patch also adds the detect pin of Orange Pi > >> Zero's mmc0 under pinctrl as it should have been there right from the > >> beginning. > > > > We're actually in the process of removing those gpio pinctrl > > nodes. Could you make that while you're at it? > > Sure. We are assuming that the bootloader will do the pin > configuration?
No, Linux will actually do it as part of the gpio(d)_request call, so the pinctrl node is actually redundant. And it prevents us from enabling stricter checks to make sure that someone isn't going to "steal" our pin by requesting a GPIO on a !GPIO line (or the other way around). This is something that is allowed at the moment, and it really shouldn't be. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: PGP signature
