On 24 January 2018 at 12:02, Maxime Ripard <[email protected]> wrote: > Hi, > > On Wed, Jan 24, 2018 at 11:39:43AM +0100, [email protected] wrote: >> From: Marcus Cooper <[email protected]> >> >> Add the DAI blocks to the device tree. I2S0 and I2S1 are for >> connecting to an external codec. >> >> Signed-off-by: Marcus Cooper <[email protected]> >> --- >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 26 >> ++++++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> index f060a58f374c..f3354f8c2026 100644 >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> @@ -419,6 +419,32 @@ >> status = "disabled"; >> }; >> >> + i2s0: i2s@1c22000 { >> + #sound-dai-cells = <0>; >> + compatible = "allwinner,sun8i-h3-i2s"; > > Same remark than for the spdif, please add a soc-specific compatible.
Is that really necessary?..for example on the a20 the functionality of the i2s is the same as the a10 so it is down as "allwinner,sun4i-a10-i2s", likewise here it's the same as the changes required for the H3. I was planning on using the compatible "allwinner,sun50i-a64-i2s" for the audio codec as there are some quirks that need to be addressed. Thanks, CK > > Thanks! > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
