On 24 January 2018 at 12:02, Chen-Yu Tsai <w...@csie.org> wrote: > On Wed, Jan 24, 2018 at 7:00 PM, Maxime Ripard > <maxime.rip...@free-electrons.com> wrote: >> On Wed, Jan 24, 2018 at 11:39:40AM +0100, codekip...@gmail.com wrote: >>> From: Marcus Cooper <codekip...@gmail.com> >>> >>> Add the SPDIF TX pin to the A64 dtsi. >>> >>> Signed-off-by: Marcus Cooper <codekip...@gmail.com> >>> --- >>> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >>> b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >>> index c82979038b0b..db1694ec3ee4 100644 >>> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >>> @@ -336,6 +336,11 @@ >>> drive-strength = <40>; >>> }; >>> >>> + spdif_tx_pins_a: spdif@0 { >> >> This will generate a dtc warning, you should use a syntax similar to >> the other nodes there (ie. spdif if that's the only muxing option, or >> spdif-0). > > Furthermore, if this is the only option, you should set it as the > default in the .dtsi, so boards don't have to, and possibly squash > this patch into the first one. ACK Thanks, CK > > ChenYu
-- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.