On Thu, Apr 18, 2019 at 07:46:58PM +0530, Jagan Teki wrote:
> Oceanic 5205 5inMFD has MCP2515 CAN device connected via SPI1.
>
> - via SPI1 bus
> - vdd supplied by 5V supply along with PL2 enable pin
> - xceiver supply same as vdd
> - can oscillator connected at 20MHz
> - PB2 gpio as interrupt pin
> - PD6 gpio as RX_BUF1_CAN0
> - PD7 gpio as RX_BUF0_CAN0
>
> Tested-by: Tamas Papp <[email protected]>
> Signed-off-by: Jagan Teki <[email protected]>
> ---
>  .../sun50i-a64-oceanic-5205-5inmfd.dts        | 43 +++++++++++++++++++
>  1 file changed, 43 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5205-5inmfd.dts 
> b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5205-5inmfd.dts
> index f0cd6587f619..22535a297f51 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5205-5inmfd.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5205-5inmfd.dts
> @@ -21,6 +21,24 @@
>       chosen {
>               stdout-path = "serial0:115200n8";
>       };
> +
> +     can_osc: can-osc {
> +             compatible = "fixed-clock";
> +             #clock-cells = <0>;
> +             clock-frequency = <20000000>;
> +     };
> +
> +     reg_can_v5v: reg-can-v5v {
> +             compatible = "regulator-fixed";
> +             regulator-name = "reg-can-v5v";
> +             regulator-min-microvolt = <5000000>;
> +             regulator-max-microvolt = <5000000>;
> +             regulator-boot-on;
> +             enable-active-high;
> +             gpio = <&r_pio 0 2 GPIO_ACTIVE_HIGH>; /* CAN_3V3_EN: PL2 */
> +             status = "okay";

You don't need the status property here.

> +     };
> +
>  };
>
>  &ehci0 {
> @@ -77,6 +95,31 @@
>       status = "okay";
>  };
>
> +&pio {
> +     can_pins: can-pins {
> +             pins = "PD6",                   /* RX_BUF1_CAN0 */
> +                    "PD7";                   /* RX_BUF0_CAN0 */
> +             function = "gpio_in";
> +     };
> +};

That isn't needed. What are they used for, you're not tying them to
anything?

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Attachment: signature.asc
Description: PGP signature

Reply via email to