On Tue, 4 Jun 2019 at 09:46, Maxime Ripard <[email protected]> wrote: > > On Mon, Jun 03, 2019 at 07:47:30PM +0200, [email protected] wrote: > > From: Marcus Cooper <[email protected]> > > > > We have a number of flags used to identify the functionality > > of the IP block found on the sun8i-h3 and later devices. As it > > is only neccessary to identify this new block then replace > > these flags with just one. > > > > Signed-off-by: Marcus Cooper <[email protected]> > > This carries exactly the same meaning than the compatible, so this is > entirely redundant. > > The more I think of it, the more I fell like we should have function > pointers instead, and have hooks to deal with these kind of things. > > I've been working a lot on that driver recently, and there's some many > parameters and regmap_fields that it becomes pretty hard to work on. Hi Maxime, let's sync with what you're doing as you're more lightly to see it through to delivery! I was trying to clean up the driver as some of this seemed a bit unnecessary, hooks sounds like the way forward, CK > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
-- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/CAEKpxBmP6UJkfzqP-AkW5sDzRcb6W9J6vM7C6DAqYVvpEKfxcQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
