On Wed, Aug 14, 2019 at 08:08:42AM +0200, codekip...@gmail.com wrote: > + if (i2s->variant->has_fmt_set_lrck_period) > + bclk_div = sun4i_i2s_get_bclk_div(i2s, clk_rate / rate, > + word_size, > + sun8i_i2s_clk_div, > + > ARRAY_SIZE(sun8i_i2s_clk_div)); > + else > + bclk_div = sun4i_i2s_get_bclk_div(i2s, oversample_rate, > + word_size, > + sun4i_i2s_bclk_div, > + > ARRAY_SIZE(sun4i_i2s_bclk_div));
Are we sure there'll never be any new variants which would make a switch statement for the variant work better? -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20190814093117.GE4640%40sirena.co.uk.
Description: PGP signature