On Fri, Oct 11, 2019 at 09:57:05AM +0200, Maxime Ripard wrote:
> On Thu, Oct 10, 2019 at 08:23:19PM +0200, Corentin Labbe wrote:
> > +   ce->reset = devm_reset_control_get_optional(&pdev->dev, "bus");
> > +   if (IS_ERR(ce->reset)) {
> > +           if (PTR_ERR(ce->reset) == -EPROBE_DEFER)
> > +                   return PTR_ERR(ce->reset);
> > +           dev_err(&pdev->dev, "No reset control found\n");
> > +           return PTR_ERR(ce->reset);
> > +   }
> 
> There's only one reset so you don't need that name.
> 
> And I'm not sure why you're using the optional variant, it's required
> by your binding.
> 


Hello

It will be fixed

Regards

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
To view this discussion on the web, visit 
https://groups.google.com/d/msgid/linux-sunxi/20191011082005.GA4641%40Red.

Reply via email to