On Mon, Dec 16, 2019 at 04:43:48PM +0200, Stefan Mavrodiev wrote:
> It's possible hdmi->connector and hdmi->encoder divices to be NULL.

The wording is broken and s/divices/devices/. I'd write:

        It's possible that the parent devices of the connector and/or
        encoder are NULL. This makes drm_connector_cleanup and
        drm_encoder_cleanup respectively trigger a NULL pointer
        exeception:

                <...log here...>

        This is reproducible by

                <...receipt here...>

        So add a check for NULL before calling these functions.

Of course this doesn't address the reservations by Maxime.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web, visit 
https://groups.google.com/d/msgid/linux-sunxi/20191217072625.rqzl2udojrxcxqd4%40pengutronix.de.

Reply via email to