Allwinner sun8i/sun50i SoCs (A31 and newer) have two interrupt controllers: GIC and R_INTC. GIC does not support wakeup. R_INTC handles the external NMI pin, and provides 16-32 IRQs to the ARISC. At least the first 16 of these correspond 1:1 to a block of GIC IRQs starting with the NMI.
This series replaces the existing chained irqchip driver used only to control the NMI, with a stacked irqchip driver that also provides wakeup capability for those 16 IRQs. The idea is that we preconfigure the ARISC's IRQ controller, and then the ARISC firmware knows to wake up as soon as it receives an IRQ. I went back and forth about updating the existing driver versus writing a new one. Since the hardware really is different from the NMI-only controller on the A20, ultimately I went with a new driver. It may be useful to separately do the chained->stacked conversion on the sunxi-nmi driver as well. Patch 1 adds the new driver. Patch 2 adds wakeup capability. The other patches update the DT+bindings to use R_INTC where beneficial. With appropriate firmware, this series allows waking from RTC, NMI/PMIC, (power button, plugging in USB, etc.), and Port L GPIO (lid switch, BT, WiFi, modem, etc.). Changes from v1: - Use writel_relaxed() instead if writel(). - Remove use of the MASK register, as it doesn't affect the NMI as seen by the GIC. It only affects the IRQs seen by the coprocessor. - Leave NMI_HWIRQ enabled at all times, since it can be masked at the GIC level (removed .irq_enable and .irq_disable). - Use .irq_ack vs .irq_eoi depending on the trigger type, to avoid missing interrupts or double interrupts. - Because of this change, the driver needs two "irq_chip"s, one with .irq_eoi set to our function and one without. - Also because of this, we need IRQ_FASTEOI_HIERARCHY_HANDLERS for handle_fasteoi_ack_irq(), so our .irq_ack function gets called while the GIC driver works as if handle_fasteoi_irq() was used. - Inline the SUNXI_SRC_TYPE_* enum into sun6i_r_intc_irq_set_type(). - Add a comment explaining how the trigger type is used. - Don't call irqd_set_trigger_type(). - Set IRQCHIP_SET_TYPE_MASKED to match the GIC (since flags from this driver mask flags from that one). - Set IRQCHIP_EOI_THREADED to avoid doubled level interrupts, since the latch will be set again as long as the trigger is met. - Replace sun6i_r_intc_domain_translate() with irq_domain_translate_twocell(). - Use an enum for the device tree binding. - Update commit messages for accuracy and typos. Samuel Holland (9): irqchip/sun6i-r: Use a stacked irqchip driver irqchip/sun6i-r: Add wakeup support dt-bindings: irq: Add a compatible for the H3 R_INTC ARM: dts: sunxi: h3/h5: Add r_intc node ARM: dts: sunxi: h3/h5: Move wakeup-capable IRQs to r_intc ARM: dts: sunxi: a83t: Move wakeup-capable IRQs to r_intc arm64: dts: allwinner: a64: Move wakeup-capable IRQs to r_intc arm64: dts: allwinner: h6: Fix indentation of IR node arm64: dts: allwinner: h6: Move wakeup-capable IRQs to r_intc .../allwinner,sun7i-a20-sc-nmi.yaml | 12 +- arch/arm/boot/dts/sun8i-a83t.dtsi | 9 +- arch/arm/boot/dts/sunxi-h3-h5.dtsi | 20 +- arch/arm/mach-sunxi/Kconfig | 4 + arch/arm64/Kconfig.platforms | 2 + arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 11 +- arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 33 ++- drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-sun6i-r.c | 267 ++++++++++++++++++ drivers/irqchip/irq-sunxi-nmi.c | 26 +- 10 files changed, 329 insertions(+), 56 deletions(-) create mode 100644 drivers/irqchip/irq-sun6i-r.c -- 2.24.1 -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20200525041302.51213-1-samuel%40sholland.org.