[linux-sunxi] [PATCH v2 03/19] common: edid: check for digital display earlier

[Jernej Skrabec]

When searching for detailed timing in EDID, check for digital display
earlier. There is no point parsing other parameters if this flag is not
present.

Reviewed-by: Andre Przywara <andre.przyw...@arm.com>
Signed-off-by: Jernej Skrabec <jernej.skra...@siol.net>
---
 common/edid.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/common/edid.c b/common/edid.c
index 553ab8fd01a1..1cb7177742e8 100644
--- a/common/edid.c
+++ b/common/edid.c
@@ -185,6 +185,11 @@ int edid_get_timing_validate(u8 *buf, int buf_size,
                return -EINVAL;
        }
 
+       if (!EDID1_INFO_VIDEO_INPUT_DIGITAL(*edid)) {
+               debug("%s: Not a digital display\n", __func__);
+               return -ENOSYS;
+       }
+
        if (!EDID1_INFO_FEATURE_PREFERRED_TIMING_MODE(*edid)) {
                debug("%s: No preferred timing\n", __func__);
                return -ENOENT;
@@ -211,10 +216,6 @@ int edid_get_timing_validate(u8 *buf, int buf_size,
        if (!timing_done)
                return -EINVAL;
 
-       if (!EDID1_INFO_VIDEO_INPUT_DIGITAL(*edid)) {
-               debug("%s: Not a digital display\n", __func__);
-               return -ENOSYS;
-       }
        if (edid->version != 1 || edid->revision < 4) {
                debug("%s: EDID version %d.%d does not have required info\n",
                      __func__, edid->version, edid->revision);
-- 
2.30.1

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
To view this discussion on the web, visit 
https://groups.google.com/d/msgid/linux-sunxi/20210306195437.9740-4-jernej.skrabec%40siol.net.