Hi Samuel, On Thu, Jul 22, 2021 at 12:35:33AM -0500, Samuel Holland wrote: > On 7/21/21 9:03 AM, Maxime Ripard wrote: > > Bluetooth SCO Link are supported by Linux with a matching device tree > > binding. > > > > Now that we have the DT validation in place, let's convert the device > > tree bindings for that driver over to a YAML schema. > > > > The value expected for #sound-dai-cells wasn't documented though, and > > the users were inconsistent. The example didn't list it, and across the > > 4 users we have in tree: > > - 1 had a cells value of 1, but using only 0 as argument > > - 1 had a cells value of 0, > > - 2 didn't have this property at all, behaving as if it was 0, > > > > It seems like the consensus seems to be that it should be 0, so let's > > enforce it. > > The driver has two DAIs: "bt-sco-pcm" and "bt-sco-pcm-wb". If > #sound-dai-cells is 0, only the first DAI can be referenced from a > device tree. So to declare support for wideband PCM, or explicitly > declare a lack of support for it, #sound-dai-cells must be 1.
Yeah, I knew there was something else to it :) I'll fix it for the next iteration. Thanks! Maxime -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20210722075803.42ltzog3sltbeivh%40gilmour.
