Hi,
On Mon, Feb 21, 2011 at 11:40 AM, Erik Gilling <[email protected]> wrote:
>> This should remove the need for calling these from specific drivers and
>> thus reduce tegra-specific code from them.
>
> It was never my intention that drives call gpio_enable/disable, just board
> files.
True, but it seems even then that it ends up in various parts of the
per-board files. Having it in one central location (for the base
config) seems like a good idea.
>> @@ -138,7 +140,18 @@ static struct tegra_pingroup_config harmony_pinmux[]
>> = {
>> {TEGRA_PINGROUP_XM2D, TEGRA_MUX_NONE, TEGRA_PUPD_NORMAL,
>> TEGRA_TRI_NORMAL},
>> };
>
> An aside: you may want to fully specify the pingroup table here. This keeps
> new bootloaders from leaving you nasty susurprises. To make this easier the
> debugfs file outputs a file you can cut and paste here.
Good point, and something i had missed myself. I'll update the harmony
file separately (make the 'enable sdmmc2' patch an 'update pinmux
table'), and refresh the seaboard patch.
> Gpio subsystem init and configurations should be left separate.
I.e. not part of the pinmux file? Sure, can do.
-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
