Thierry Reding wrote at Wednesday, December 21, 2011 2:12 AM: > * Stephen Warren wrote: > > Thierry Reding wrote at Tuesday, December 20, 2011 3:32 AM: > > > From: Simon Que <[email protected]> > > > > > > PWM clock source registers in Tegra 2 have different clock source > > > selection bit ... > > > Also, adjusts for the frequency divider being offset by 1. > > > > That last line applies to the original patch in the ChromeOS tree, but > > not to the patch you posted (the edit to arch/arm/mach-tegra/pwm.c that > > was in the original patch isn't part of this patch). > > Right, I've adjusted the commit message to take that into account. I assume > the commit now also requires my Signed-off-by because I actually modified the > patch? This would be true even in the previous version because I had to make > some small adjustments.
All patches you send need you S-o-b line. This is true whether you modified the patch or not. When modifying a patch someone else wrote, it's typical to include some notes on what you changed, e.g.: Signed-off-by: Original author <...> [swarren: Fixed checkpatch warnings] Signed-off-by: You <...> Or perhaps for larger changes that don't inline between the S-o-b very well, put it above all the S-o-b. -- nvpbulic -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
