On Mon, 2012-05-14 at 18:20 +0200, Kay Sievers wrote: > On Mon, May 14, 2012 at 6:18 PM, Hiroshi DOYU <[email protected]> wrote: > > Add missing prepend_timestamp() dummy. > > That was fixed already last week: > http://git.kernel.org/?p=linux/kernel/git/gregkh/driver-core.git;a=commitdiff;h=1fce677971e29ceaa7c569741fa9c685a7b1052a
Yup, but in my opinion, this particular fix shouldn't be necessary because the CONFIG_PRINTK bits should have better code separation. None of the code that calls prepend_timestamp should actually be compiled in when !CONFIG_PRINTK. The same is true for unnecessary uses like the existing per-cpu: static DEFINE_PER_CPU(int, printk_pending); static DEFINE_PER_CPU(char [PRINTK_BUF_SIZE], printk_sched_buf); After this patchset is accepted into mainline, I'll revive the modularization and move of kernel/printk.c and associated files into -> kernel/printk/* patch I did awhile ago. I'll follow-on to this message with the original patches just as an fyi/rfc. cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
