On 02/20/2013 07:56 AM, Russell King - ARM Linux wrote:
> On Mon, Feb 18, 2013 at 07:30:29PM +0800, Wei Ni wrote:
>> +static struct tegra_thermal_data * __devinit thermal_tegra_dt_parse_pdata(
>
> __dev* no longer exists.
Ok, I will change it.
>
>> + tdata = devm_kzalloc(&pdev->dev, sizeof(*tdata), GFP_KERNEL);
>> + if (!tdata) {
>> + dev_err(&pdev->dev, "Can't allocate platform data\n");
>> + return NULL;
>> + }
>> + memset(tdata, 0, sizeof(*tdata));
>
> Useless memset. k*z*alloc already zeros the memory before returning.
Yes, I forgot to remove this line.
>
>> +static int tegra30_thermal_probe(struct platform_device *pdev)
>> +{
>> + struct tegra_thermal_data *pdata = pdev->dev.platform_data;
>
> You read pdata here....
>
>> + struct thermal_zone *tz;
>> + struct thermal_sensor *ts;
>> + static struct thermal_cooling_device *cdev;
>> + int ret;
>> +
>> + pdata = thermal_tegra_dt_parse_pdata(pdev);
>
> and immediately overwrite it here.
>
>> + if (!pdata) {
>> + dev_err(&pdev->dev, "Get platform data failed.\n");
>> + return -EINVAL;
>> + }
>> +
>> + /* Create a thermal zone */
>> + tz = create_thermal_zone("tz_tegra", NULL);
>> + if (!tz) {
>> + dev_err(&pdev->dev, "Create thermal_zone failed.\n");
>> + return -EINVAL;
>> + }
>> +
>> + pdata->tz = tz;
>
> This isn't how you deal with driver data. Set driver data against a
> platform device using platform_set_drvdata(pdev, tz).
Yes, I didn't consider it carefully.
As Stephen said, our tegra will only support DT, so I will remove the
platform date.
Thanks.
Wei.
>
>> +static int tegra30_thermal_remove(struct platform_device *pdev)
>> +{
>> + struct tegra_thermal_data *pdata = pdev->dev.platform_data;
>
> and use platform_get_drvdata() here - and don't use pdata->tz.
> struct struct thermal_zone *tz = platform_get_drvdata(pdev);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
