On 03/11/2013 04:30 PM, Andrew Chew wrote:
> This patch adds device tree nodes for the four PWM controllers present
> on tegra114.

Nit: Capitalize Tegra.

> diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi

> @@ -150,4 +150,36 @@
>                            <1 11 0xf08>,
>                            <1 10 0xf08>;
>       };

DT nodes should be sorted in order by reg address, so I think this is in
the wrong place.

> +     pwm0: pwm@7000a000 {
> +             compatible = "nvidia,tegra20-pwm";

If the HW is 100% backwards-compatible, that should be:

compatible = "nvidia,tegra114-pwm", "nvidia,tegra20-pwm";

if not:

compatible = "nvidia,tegra114-pwm";

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to