On Wed, 2013-03-20 at 00:40 +0800, Stephen Warren wrote: > On 03/18/2013 02:09 AM, Joseph Lo wrote: > > The clock source of PMC should be PCLK and gotten from DT. > > > > Signed-off-by: Joseph Lo <[email protected]> > > --- > > V2: > > * new in this change > > s/change/series/ ??? > > > diff --git a/arch/arm/mach-tegra/common.c b/arch/arm/mach-tegra/common.c > > > void __init tegra_dt_init_irq(void) > > { > > tegra_clocks_init(); > > + tegra_pmc_init(); > > tegra_init_irq(); > > irqchip_init(); > > } > > @@ -100,7 +101,6 @@ void __init tegra_init_early(void) > > tegra_apb_io_init(); > > tegra_init_fuse(); > > tegra_init_cache(); > > - tegra_pmc_init(); > > This change isn't mentioned in the commit description. > > Why is this change needed? We should minimize the amount of code in > tegra_dt_init_irq(), not add more code there. > The clocks only available after tegra_clocks_init(). If I can keep the PMC dt node somewhere in PMC driver, then I can get the clock later.
> > diff --git a/arch/arm/mach-tegra/pmc.c b/arch/arm/mach-tegra/pmc.c > > > @@ -151,6 +153,8 @@ static void tegra_pmc_parse_dt(void) > > > > tegra_pmc_invert_interrupt = of_property_read_bool(np, > > "nvidia,invert-interrupt"); > > + tegra_pclk = of_clk_get(np, 0); > > + WARN_ON_ONCE(IS_ERR(tegra_pclk)); > > Why WARN_ON_ONCE(); is tegra_pmc_parse_dt() called more than once? > > Can the code continue if IS_ERR(tegra_pclk), or is that fatal? > The code is still OK just want to warn people that the PMC DT node needs PCLK clock info. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
