On 10/18/2013 04:26 AM, Hiroshi Doyu wrote: > Create default IOVA maps at boot-up which can be attached to devices.
What's the content of those default maps? I assume no RAM is mapped, judging by the code. If so, perhaps s/default/default empty/ in the patch description? > @@ -1236,7 +1261,7 @@ static int tegra_smmu_probe(struct platform_device > *pdev) > smmu_debugfs_create(smmu); > smmu_handle = smmu; > bus_set_iommu(&platform_bus_type, &smmu_iommu_ops); > - return 0; > + return tegra_smmu_create_default_map(smmu); > } If tegra_smmu_create_default_map() fails, don't you need to unwind e.g. bus_set_iommu(), and any other setup that happened before? -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
