On Tue, Oct 29, 2013 at 03:07:57AM +0100, Wei Yongjun wrote: > From: Wei Yongjun <[email protected]> > > In case of error, the function __clk_lookup() returns NULL pointer > not ERR_PTR(). The IS_ERR() test in the return value check should > be replaced with NULL test. > > Signed-off-by: Wei Yongjun <[email protected]> > --- > drivers/clk/tegra/clk-pll.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c > index 197074a..a99bef7 100644 > --- a/drivers/clk/tegra/clk-pll.c > +++ b/drivers/clk/tegra/clk-pll.c > @@ -1507,7 +1507,7 @@ struct clk *tegra_clk_register_pllc(const char *name, > const char *parent_name, > return ERR_PTR(-EINVAL); > > parent = __clk_lookup(parent_name); > - if (IS_ERR(parent)) { > + if (!parent) { > WARN(1, "parent clk %s of %s must be registered first\n", > name, parent_name); > return ERR_PTR(-EINVAL); >
Ah :( There are a few more instances of this. I will fix them all. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
